Skip to content

telemetry(amazonq): use run block instead of emit #6302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmk3 merged 2 commits into from
Jan 6, 2025
Merged

telemetry(amazonq): use run block instead of emit #6302

justinmk3 merged 2 commits into from
Jan 6, 2025

Conversation

@dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Jan 2, 2025

Problem

run > emit

Solution

Fix

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners January 2, 2025 23:57
@github-actions
Copy link

github-actions bot commented Jan 2, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

dhasani23
dhasani23 commented Jan 3, 2025
View reviewed changes
packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts
codeTransformStatus: transformByQState.getStatus(),
userChoice: 'Cancel',
result: MetadataResult.Pass,
})
Copy link
Contributor Author

@dhasani23 dhasani23 Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and above, viewArtifact isn't necessary since we already have submitSelection

aws-toolkit-common package PR to remove viewArtifact will be out shortly

Copy link
Contributor Author

@dhasani23 dhasani23 Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws/aws-toolkit-common#948

justinmk3
justinmk3 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@justinmk3 justinmk3 merged commit 7e788c5 into aws:master Jan 6, 2025
25 of 26 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
@dhasani23 @karanA-aws
telemetry(amazonq): use run() instead of emit() aws#6302
3514601
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
@dhasani23 @s7ab059789
telemetry(amazonq): use run() instead of emit() aws#6302
aff0a3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justinmk3 justinmk3 justinmk3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhasani23 @justinmk3